Improve template manager/generation#816
Merged
gabriel-samfira merged 1 commit intoJul 7, 2026
Merged
Conversation
This change parses the runner install template on creation or update. It does not "execute" the template, as that requires full template context which may vary depending on extra_specs, but the syntax is checked. Additionally, when a template is rendered (requested by a runner), the wrapper template will now catch the error and phone it home, marking the runner as failed. This will at least surface the error instead of leaving the runner in "installing" forever and only printing the error message to the garm log. Changes have been made to the CLI as well to notify the user that the template has an error, dropping them back into the editor. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
better-template-handling
branch
from
2713de6 to
73c4f07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change parses the runner install template on creation or update. It does not "execute" the template, as that requires full template context which may vary depending on extra_specs, but the syntax is checked.
Additionally, when a template is rendered (requested by a runner), the wrapper template will now catch the error and phone it home, marking the runner as failed. This will at least surface the error instead of leaving the runner in "installing" forever and only printing the error message to the garm log.
Changes have been made to the CLI as well to notify the user that the template has an error, dropping them back into the editor.
Drive by update: updated garm-provider-common, which replaced the yaml parser with the one maintained by the YAML organization. That is the bulk of the files changed. Should have probably pushed that separately.